Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ISO checksum algorithm configurable #45

Closed
wants to merge 2 commits into from
Closed

Make ISO checksum algorithm configurable #45

wants to merge 2 commits into from

Conversation

tigattack
Copy link

Pull Request Template

By contributing, you agree that your contributions will be licensed under the projects original open source license.

Description

This PR makes the ISO checksum algorithm configurable. It was previously forced to sha256, but sha256 checksums are not provided on most download pages (ex. B&R download page provides sha1 and md5 sums).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Executed the role, start to finish, using my own ISO URL and sha1 checksum from the download page. Worked fine.

Checklist (check all applicable):

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard to understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@carceneaux
Copy link
Contributor

Thanks for bringing this up, @tigattack!

You make a good point as only MD5 and SHA1 hashes are available on Veeam's website.

I plan on implementing this in a slightly different manner so I created issue #46 and I'm closing this PR.

Expect a new release with these changes within the next 2 or 3 weeks.

@carceneaux carceneaux closed this Apr 28, 2023
@carceneaux
Copy link
Contributor

A bit late but this functionality is now present in the current release of this collection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants