Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master branch to 1.0.4.99 #705

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Conversation

CaveSpectre11
Copy link
Collaborator

Problem

master branch builds are still at 1.0.3.99 instead of 1.0.4.99

Root cause

It wasn't updated to 1.0.4.99 when 1.0.4 was first released

Solution

Bump it now so it's done

Notes

This is only affecting the master branch, and is code that changes on release branches. Really only a little missed paperwork when 1.0.4 was created, and should be a trivial merge.

Copy link
Contributor

@mimirmim mimirmim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK #705

@CaveSpectre11 CaveSpectre11 added Component: Core App Related to the application itself. Tag: Waiting For Code Review Waiting for code review from a core developer labels Dec 12, 2019
Copy link
Collaborator

@codeofalltrades codeofalltrades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK af76e5b

image

@codeofalltrades codeofalltrades added Code Review: Passed and removed Tag: Waiting For Code Review Waiting for code review from a core developer labels Dec 12, 2019
codeofalltrades added a commit that referenced this pull request Dec 12, 2019
af76e5b Update master branch to 1.0.4.99 (CaveSpectre11)

Pull request description:

  ### Problem
  master branch builds are still at 1.0.3.99 instead of 1.0.4.99

  ### Root cause
  It wasn't updated to 1.0.4.99 when 1.0.4 was first released

  ### Solution
  Bump it now so it's done

  ### Notes
  This is only affecting the master branch, and is code that changes on release branches.  Really only a little missed paperwork when 1.0.4 was created, and should be a trivial merge.

Tree-SHA512: fbe8c082feb8a6f810628b70c1a014f3f51b9c53ba8a3e3f1ffa1eb1e2040bfbd4f404b8f3df16f4db832c58c3017b45a58e9dabff618a14f4ed7d01d2c003b5
@codeofalltrades codeofalltrades merged commit af76e5b into master Dec 12, 2019
@CaveSpectre11 CaveSpectre11 deleted the CaveSpectre11-patch-1 branch December 13, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Review: Passed Component: Core App Related to the application itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants