[Mining] Recent mining hash speed #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This grants each mining thread within the wallet a struct to store the hashrate from its most recent round. `getmininginfo` will return the sum of these in `hashspeed_recent` as a best approximation. The threads also individually log their hashrate alongside the full hashrate.
Zannick
added
Tag: PoW
Zannick
requested review from
blondfrogs,
CaveSpectre11 and
codeofalltrades
CaveSpectre11
requested review from
WetOne
and removed request for
blondfrogs
Repository owner
deleted a comment from
Curay1954
Sep 23, 2021
CALISOULB
approved these changes
Sep 24, 2021
CaveSpectre11
added
Code Review: Passed
Tag: Waiting For QA
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
utACK 79102e2 |
WetOne
approved these changes
Sep 26, 2021
This comment has been minimized.
This comment has been minimized.
Repository owner
deleted a comment from
Curay1954
Sep 27, 2021
This comment has been minimized.
This comment has been minimized.
Merged
Zannick
removed
the
Tag: Waiting For QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In
getmininginfo, it isn't clear that it computes thehashspeedby counting all hashes made since the start of hashing and dividing by the elapsed time, which tends to smooth out fluctuations but also (prior to #966) can include periods of time when the miner is off or the number of threads different.Solution
This adds a field to
getmininginfocalledhashspeed_recentwhich is a sum of each thread's most recent round of hashing (where a round is either a fixed number of hashes or ends with a new block).Tested
On regtest chain with sha256d and randomx.