[RPC][Wallet] Create multiple transactions with one command. #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zannick
added
Component: Wallet
|
|
RPC send commands have a new argument now that controls whether the amount specified can be split across multiple transactions. It defaults to single-transaction mode for now. SelectCoinsForOneTx: use a sliding window algorithm to pick inputs. This will pick one small input if possible, so that if change is produced it does not result in an ever-growing pile of tiny utxos.
|
Changed to use |
WetOne
approved these changes
Mar 18, 2022
|
utACK a872b41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
RPC send commands have a new argument
inputs_per_txthat controls whether the amount specified can be split across multiple transactions. This value ranges from 0 (default) to 32 (an upper bound designed to prevent transactions larger than can be accepted). When set to 0, attempts to fit the send in one transaction as per previous behavior.The sends are interpreted to mean that the recipient will receive the sent amount, but under the hood the transactions are created as if
subtractfeefromamountwas specified. In particular, if the send needs to be split inton > 1transactions, the outputs of the firstn - 1are randomly reduced to account for the fee (and the shortfall from the inputs).Coins are selected using a sliding window that prioritizes cleaning up small utxos (dust) over using fewer inputs, and thus transactions built this way will tend toward having more inputs. This is beneficial for ringct staking (keeping larger coins intact and reducing the amount of small utxos). The smallest utxo is always included if possible to prevent the amount of small utxos from increasing with usage.
Tested
On regtest some months ago.