Set cookies when playing a track #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized this needs to obey the |
Uses `HTTPCookie.cookies(withResponseHeaderFields:for:)` to generate cookies from the `response`'s `allHeaderFields`. It then sets those cookies using `configuration.httpCookieStorage.setCookies(_:for:mainDocumentURL:)`. The documentation for `setCookies(_:for:mainDocumentURL:)` even says this is the correct way to do this.
mluisbrown
reviewed
Jul 13, 2018
Vinyl/Turntable.swift
Outdated
| @@ -103,6 +103,12 @@ public final class Turntable: URLSession { | |||
|
|
|||
| return URLSessionTask { | |||
| self.operationQueue.addOperation { | |||
| // Set cookies | |||
| if request.httpShouldHandleCookies, let cookieStorage = self.configuration.httpCookieStorage, let httpResponse = completion.response as? HTTPURLResponse, let headerFields = httpResponse.allHeaderFields as? [String: String], let url = httpResponse.url { | |||
There was a problem hiding this comment.
Formatting: could you put each let x = on a new line? Looks good otherwise.
mluisbrown
requested changes
Jul 13, 2018
There was a problem hiding this comment.
Thanks for this @brentleyjones, and apologies for the PR being ignored for so long.
Just have one small formatting comment 👍
mluisbrown
approved these changes
Aug 15, 2018
dmcrodrigues
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
HTTPCookie.cookies(withResponseHeaderFields:for:)to generate cookies from theresponse'sallHeaderFields. It then sets those cookies usingconfiguration.httpCookieStorage.setCookies(_:for:mainDocumentURL:). The documentation forsetCookies(_:for:mainDocumentURL:)even says this is the correct way to do this.