Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed in base_ga4__events.sql - BUG #31 #32

Merged
merged 1 commit into from
Jul 19, 2022
Merged

fixed in base_ga4__events.sql - BUG #31 #32

merged 1 commit into from
Jul 19, 2022

Conversation

vibhorj
Copy link
Contributor

@vibhorj vibhorj commented Jul 19, 2022

Description & motivation

As discussed in Bug #31
It seems Jinja does not recognize non-null value as true

Checklist

  • [yes ] I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@adamribaudo-velir
Copy link
Collaborator

Great catch. Thanks!

@adamribaudo-velir adamribaudo-velir merged commit caf16e3 into Velir:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants