Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ENDPOINT: update notifier to look at doc_type #140

Conversation

darmstrong-r7
Copy link
Contributor

This PR updates notifier to look at doc_type for notifications.

@scudette
Copy link
Contributor

scudette commented Jun 4, 2024

The way notifications work is as a toggle switch. That means you get multiple notifications the receiver will only get a single notification.

That's why we just write to a doc id and then read it periodically. It doesn't matter how many times we write to it but we only notify once.

When we folded all the records into the same index the doc id clashed. So here we need to uniquify the doc id by adding a suffix like "_notify" for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants