Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ongoing revisions #100

Merged
merged 3 commits into from
May 7, 2017
Merged

Ongoing revisions #100

merged 3 commits into from
May 7, 2017

Conversation

Kerbas-ad-astra
Copy link
Contributor

No description provided.

@Kerbas-ad-astra Kerbas-ad-astra changed the title Bump version file to get the right KSP version. Ongoing revisions May 6, 2017
@VenVen VenVen merged commit 155704b into VenVen:master May 7, 2017
@khr15714n
Copy link
Contributor

Started KSP:
KSP Add-on Version Checker
VenStockRevamp 1.9.5 (current) 1.9.7 (avail)

Installed through CKAN, listed as 1.9.6
1st came here, wondered were 1.9.7 is and download 1.9.6
Compared installed files with downloaded ... 100% identical
downloaded (github) VenStockRevamp.version reads
"VERSION": {
"MAJOR": 1,
"MINOR": 9,
"PATCH": 5
},
"KSP_VERSION": {
"MAJOR": 1,
"MINOR": 1,
"PATCH": 3
}
while
http://forum.kerbalspaceprogram.com/index.php?/topic/83696-122-stock-part-revamp-update-196-released-source-files/
reads 1.2.2 and version 1.9.6

@blowfishpro
Copy link
Contributor

@khr15714n It only shows up on CKAN when there's an official release, however AVC will check whatever is in the repository.

@khr15714n
Copy link
Contributor

@blowfishpro As described in my original post, CKAN served me https://github.com/VenVen/Stock-Revamp/releases/tag/v1.9.6, released on Feb 4th.
VenStockRevamp.version still claims to be version 1.9.5 while it's actually 1.9.6

What I failed to mention exactly in my original post: On May 5th @Kerbas-ad-astra changed another 3 files

On start KSP showed a conflict: 1.9.5 (current) and 1.9.7 (available).
Updating the 3 files manually and changing the version file solved the problem KSP showing the conflict (for me).
Nonetheless the v1.9.6.zip has an outdated version file claiming to be 1.9.5 instead of 1.9.6.

While I came here was based on a new conflict (1.9.5 vs 1.9.7) the old one (1.9.5 vs 1.9.6) is still viable.

@blowfishpro
Copy link
Contributor

Okay, so the problem is that the .version file in the 1.9.6 download actually says 1.9.5

@khr15714n
Copy link
Contributor

That's what @tstivers1990 reported on April 17th in #105
@Kerbas-ad-astra "Should be fixed by #100." on May 7th
A few hours later @VenVen merged the files but has not officially released 1.9.7 yet.
I downloaded and installed the mod on May 9th and on start KSP showed the (new) conflict between 1.9.5 (local version file) and 1.9.7 (github).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants