Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MusicTitleRPC plugin #2483

Closed
wants to merge 25 commits into from
Closed

Conversation

Blackilykat
Copy link

Changes the name of music rich presences to inherit the currently playing song's title.
musictitlerpc

@Vendicated
Copy link
Owner

pretty sure this breaks spotify activity timebar

@Blackilykat
Copy link
Author

pretty sure this breaks spotify activity timebar

It does, I attempted to recreate spotify's activity as close as possible but I believe giving up some spotify exclusive features is the only way to have a custom name for it

@Blackilykat
Copy link
Author

Oh by the way - I copied the activity interfaces from CustomRPC. Don't know if I should add anyone to authors for that

@Scyye
Copy link
Contributor

Scyye commented May 19, 2024

pretty sure this breaks spotify activity timebar

I'd add a disclaimer of some sort letting you know of that.

Scyye

This comment was marked as outdated.

Copy link
Contributor

@Scyye Scyye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this doesnt apply to any of the specific parts, but im pretty sure you need to add a README.md

src/plugins/musicTitleRPC/index.tsx Outdated Show resolved Hide resolved
src/plugins/musicTitleRPC/index.tsx Show resolved Hide resolved
src/plugins/musicTitleRPC/index.tsx Outdated Show resolved Hide resolved
src/plugins/musicTitleRPC/index.tsx Outdated Show resolved Hide resolved
src/plugins/musicTitleRPC/index.tsx Outdated Show resolved Hide resolved
@n1ckoates
Copy link
Contributor

This no longer breaks the timebar because it's shown for all listening activities, not just Spotify.

IMO Spotify stuff might work better in it's own plugin, feels a bit out of scope for this one.

@Blackilykat
Copy link
Author

IMO Spotify stuff might work better in it's own plugin, feels a bit out of scope for this one.

I put it all in one because I thought it would only cause confusion to have it split. It achievss the same goal for both

@Blackilykat
Copy link
Author

closing in favor of #2495

@Blackilykat Blackilykat closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants