-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MusicTitleRPC plugin #2483
Add MusicTitleRPC plugin #2483
Conversation
pretty sure this breaks spotify activity timebar |
It does, I attempted to recreate spotify's activity as close as possible but I believe giving up some spotify exclusive features is the only way to have a custom name for it |
Oh by the way - I copied the activity interfaces from CustomRPC. Don't know if I should add anyone to authors for that |
I'd add a disclaimer of some sort letting you know of that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this doesnt apply to any of the specific parts, but im pretty sure you need to add a README.md
This no longer breaks the timebar because it's shown for all listening activities, not just Spotify. IMO Spotify stuff might work better in it's own plugin, feels a bit out of scope for this one. |
I put it all in one because I thought it would only cause confusion to have it split. It achievss the same goal for both |
closing in favor of #2495 |
Changes the name of music rich presences to inherit the currently playing song's title.