-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port volume booster to web/vesktop #2730
Conversation
298d27f
to
7406f4d
Compare
7406f4d
to
8dff21d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works but idk if it really is 200% volume sounds like the "fix" you told me you made where it was 2x the volume it was supposed to be is actually what is intended
tl;dr: i think your fix broke it more
It does raise the volume but it doesnt seem to be ex: 500% louder. also it basically functions as a fake deafen at the moment.,... |
yeah this was my experience too
we cannot ship that, theres a good reason why fake deafen is explicitly not a feature, regardless of that I think I'd still like to have a "I want my friends to be quiet for a bit" button |
somehow I didn't notice this, thanks! |
You are doing two webpack searches yet only one is used, remove the other one also the code style doesn't match the rest of project, mainly the spacing in if conditions |
Co-authored-by: v <vendicated@riseup.net>
I may be a tad stupid, but what are/were you referring to by the spacing in if conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like nuckyz said, follow the code style
Co-authored-by: v <vendicated@riseup.net>
Co-authored-by: v <vendicated@riseup.net>
i think it would be a good idea to extract this into a separate plugin like WebExtraVolume and make it enabled by default. That way more users can profit from it and Vesktop users will get the expected stock equivalent behaviour |
It depends on the patches already introduced by Volume Booster. |
Is there anything I can help with to get this merged? :) Would love to have this feature on web/vesktop |
This should be ready as i fixed the stock discord issue that made it glitch out at low volumes |
Thank you! |
Apparently this isn't working on the vesktop, which is weird because that's where I tested it. I have family over today, but I will work on it tomorrow if nobody else fixes it |
resolves: #1944
ports volume booster to web/vesktop
TODO: