Update trait to use boot<TRAIT NAME> instead of defining a static boot function. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… function. This is to allow it to work better with model which also defined their own static boot
duellsy
added a commit
that referenced
this pull request
Aug 3, 2014
…t_trait Update trait to use boot<TRAIT NAME> instead of defining a static boot function.
|
I merged this in, but then rolled back since it won't actually work with laravel <= 4.2.6 |
|
Ah too bad then. I will keep a patch file on my install then. Thanks Chris. |
|
Perhaps you could provide this patch through I noticed that the package didn't worked with some of my models exactly for that reason. The odd thing is that it simply doesn't work, and for that reason it was not an easy task to figure out what was happening. I think that issuing a warning on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Chris, this pull request is to make the trait works better with model, whereby if models define their own static boot function, the one defined in traits will not be used. By defining "trait boot" function, this will guarantee (within certain parameter) that the "trait boot" static function will always be called.