This repository has been archived by the owner on May 19, 2024. It is now read-only.
DateTimeOffset String Formatting #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What was the advantage of using the ToShortDateString method in the first place? If there's no significant advantage, I think we should go back to using the ToString method with a format provided. Or at least we could change back to that for now so that our code can run. |
|
@julietdaniel So before, we were using DateTime which had a ToShortDateString that took care of the formatting for us, but (I'm pretty sure) DateTimeOffset doesn't have this method, which is why we have to format it ourselves. But yeah exactly, we need to switch back if we even want it to run. |
julietdaniel
approved these changes
Aug 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTimeOffset does not have the ToShortDateString method so I changed it back to the ToString method with a format provided. This was causing an error on the Index page and Post page. Related to #50