Number predicate

[kilohsakul]

The class for initial and final states, with constant test and update (sort of constant),
pruning the additions removals etc from the interface of NFA,
some other small changes.
(The class can be also used for tagging things in case the tags then must be reset,
one could e.g. use it in reachability, make the tags static, reset them after every run :). )
Some algoroithms such as complementation are not yet updated to work with final/initial states reasonably, for later.

[kilohsakul]

Ok, now there are at least no conflicts. There were conflicts because of moving things around and renaming files, I hope I did not mess something up.

I will need Lachtan to help with the python binding, pretty please.

[Adda0]

This is a first quick review of the introduced changes. The idea of introducing classes for initial and final states makes sense to me and I support it. Whether it works well for us, that remains to be seen. In general, In general, I have no serious issues with the PR, the mentioned problems are mostly of cosmetic character. I will do a proper review of the functionality of the introduced NumPredicate later.

[kilohsakul]

not sure I will have time to go through all comments, sorry

[Adda0]

No worries. Someone else from us can resolve these when the Python binding gets fixed before merging the PR.

[tfiedor]

I like the idea, I think the code is fine, however, I would prefer if we discussed the naming around the elements part, because I feel it could be better. I proposed some initial suggestions, but I know we can do better.

Also delegate some minor fixes to some oompa loompa (martin, juraj, david).

[martinhruska]

Once all notes are addressed I approve PR.

[martinhruska]

We need to progress this somehow. Lukas addressed some of your comments, please check them and eventually mark them as solved.

[Adda0]

Besides what was already mentioned above and what we have discussed. The introduced functionality looks good to me.

[martinhruska]

@tfiedor Could you please fix the binding?

[tfiedor]

@tfiedor Could you please fix the binding?

I will, once Mr. L commands me, that he is finished with his changes.

[kilohsakul]

merge it merge it!

[martinhruska]

Based on request by Lukas, I merge this PR. Biding will be fixed later.

[tfiedor]

I think that was a bad call, is there a reason why we had to merge it right now?

[kilohsakul]

Yes, we need to speed this up, in order to be able to use the up-to-date mata in the string solver, we need to work intensively on the string solver now.

[kilohsakul]

Deadline close.