🗑 refactor(loss, nn, recipes, transforms, optim): remove unused local variables #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vermeille
requested changes
Apr 28, 2021
| @@ -40,8 +40,6 @@ def step(self, closure=None): | |||
| # Perform stepweight decay | |||
| p.data.mul_(1 - group['lr'] * group['weight_decay']) | |||
|
|
|||
| state = self.state[p] | |||
|
|
|||
There was a problem hiding this comment.
I don't feel quite good about removing this one actually. Commenting this line would feel better. I don't want to forget that there is an inherited state dict that could be extremely helpful.
There was a problem hiding this comment.
In which way could it be extremely helpful? Could a comment about that as a reminder instead of an unused variable be more fitting? 🙂
| @@ -192,7 +192,6 @@ class PerceptualDiscriminator(nn.Module): | |||
| @tu.experimental | |||
| def __init__(self, n_downscales=4): | |||
| super().__init__() | |||
| layers = tu.FrozenModule(tch.models.PerceptualNet(layers)) | |||
There was a problem hiding this comment.
Disregard everything in this file.
There was a problem hiding this comment.
Should I take it as a request to keep this line in and revert this change from the PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.