Add support for custom DynamoDB table. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,7 +104,7 @@ func (slice ByName) Less(i, j int) bool { | |||
| } | |||
|
|
|||
| // Setup create the table which stores credentials | |||
| func Setup() (err error) { | |||
| func Setup(Table *string) (err error) { | |||
There was a problem hiding this comment.
Can you just change Table to tableName in all calls, this matches the normal golang convention.
Aside from that it looks fantastic!
Thanks again.
There was a problem hiding this comment.
Fair point, did that in main.go after noticing it collided with the table variable used for the TableWriter.
|
👍 will do some testing and cut a release tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solution to #32. Passes unit tests, no integration tests done.