Fixes auto-versioning to support left-padding #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 amazing pull request, thanks for taking the time to document the changes. I will update the mock which broke tests, time to regenerate these during build to avoid this in the future. Will triage the mock issue then merge this later tonight Melbourne/AU time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unicreds doesn't left-pad the version (#34), resulting in the same bug as credstash had (fugue/credstash#51) where versions after 10 don't sort properly.
This change left-pads the version if it is automatically calculated using
ResolveVersionor set as the first version viaPut.I added a note the README describing how someone might migrate, pointing to the credstash script to update.