-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create flutter plugin new usage #617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renancaraujo
force-pushed
the
feat/flutter-plugin-usage
branch
from
January 10, 2023 13:27
cd3bffe
to
0cc4ecf
Compare
wolfenrain
previously approved these changes
Jan 10, 2023
felangel
reviewed
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no e2e test for the plugin?
felangel
previously approved these changes
Jan 10, 2023
No, there never was |
renancaraujo
dismissed stale reviews from felangel and wolfenrain
via
January 10, 2023 17:28
99c72fd
renancaraujo
force-pushed
the
feat/flutter-plugin-usage
branch
2 times, most recently
from
January 10, 2023 17:31
99c72fd
to
0b8518b
Compare
renancaraujo
force-pushed
the
feat/flutter-plugin-usage
branch
from
January 11, 2023 10:48
0b8518b
to
328e272
Compare
Created a card for the lack of e2e #619 |
felangel
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #587
Type of Change