Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create flutter plugin new usage #617

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Conversation

renancaraujo
Copy link
Contributor

@renancaraujo renancaraujo commented Jan 10, 2023

Description

closes #587

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

wolfenrain
wolfenrain previously approved these changes Jan 10, 2023
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no e2e test for the plugin?

felangel
felangel previously approved these changes Jan 10, 2023
@renancaraujo
Copy link
Contributor Author

renancaraujo commented Jan 10, 2023

Is there no e2e test for the plugin?

No, there never was

@renancaraujo renancaraujo dismissed stale reviews from felangel and wolfenrain via 99c72fd January 10, 2023 17:28
@renancaraujo renancaraujo force-pushed the feat/flutter-plugin-usage branch 2 times, most recently from 99c72fd to 0b8518b Compare January 10, 2023 17:31
@renancaraujo
Copy link
Contributor Author

Created a card for the lack of e2e #619

@renancaraujo renancaraujo merged commit 0a8bef5 into main Jan 11, 2023
@renancaraujo renancaraujo deleted the feat/flutter-plugin-usage branch January 11, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(create)! subcommand: Very Good Flutter Plugin Usage
3 participants