Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test optimizer brick #639

Merged
merged 12 commits into from
Feb 13, 2023
Merged

feat: add test optimizer brick #639

merged 12 commits into from
Feb 13, 2023

Conversation

renancaraujo
Copy link
Contributor

Description

feat: add test optimizer brick

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@renancaraujo renancaraujo force-pushed the renan/add-test-optimizer-brick branch 3 times, most recently from 58c9430 to f87e4fe Compare February 8, 2023 13:27
@renancaraujo renancaraujo marked this pull request as ready for review February 8, 2023 13:40
felangel
felangel previously approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from Erick's comment

wolfenrain
wolfenrain previously approved these changes Feb 10, 2023
View reviewed changes
@renancaraujo @erickzanardo
Update bricks/test_optimizer/brick.yaml
866a62b 
Co-authored-by: Erick <erickzanardoo@gmail.com>
@renancaraujo renancaraujo merged commit 3f8434e into main Feb 13, 2023
@renancaraujo renancaraujo deleted the renan/add-test-optimizer-brick branch February 13, 2023 13:25
This was referenced Feb 13, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

@felangel felangel Awaiting requested review from felangel

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

Assignees

@renancaraujo renancaraujo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@renancaraujo @erickzanardo @felangel @wolfenrain