Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidden elements on top of visibile ones #21

Closed
xrmx opened this issue Apr 9, 2014 · 10 comments
Closed

hidden elements on top of visibile ones #21

xrmx opened this issue Apr 9, 2014 · 10 comments

Comments

@xrmx
Copy link

xrmx commented Apr 9, 2014

On ie9 i have hidden elements on top of visible ones, wouldn't make sense to play with z-index or set them display: none to avoid this kind of issues? On decent browsers of course it works fine :)

@xrmx
Copy link
Author

xrmx commented Apr 9, 2014

Adding show() and hide() fixes #20 and #21 for me on ie8/9. Do you think this is something can be handled in the library itself?

       $('#grid').shuffle('shuffle', function($el, shuffle) {
                    var category = $('#grid').data('category');

                    if (category == 'all') {
                            $el.show();
                            return true;
                    }
                    if ( $el.data('groups') == category ) {
                            $el.show();
                            return true;
                    } else {
                            window.setTimeout(function() {
                                    $el.hide();
                            }, 200);
                            return false;
                    }
            });

@Vestride
Copy link
Owner

Vestride commented Apr 9, 2014

I don't see hidden elements on top of visible ones. Can you provide a link/demo to where it's not working, or steps of how to reproduce it from my demos?

@xrmx
Copy link
Author

xrmx commented Apr 10, 2014

Demos works fine here too, will provide a test case

@MikiMoon
Copy link

Here's the test case https://gist.github.com/MichiUB/10470157

@Vestride
Copy link
Owner

@MichiUB please provide a better test case. See here for more details. https://github.com/Vestride/Shuffle#submitting-issues

@MikiMoon
Copy link

Here's a better one, if hover the link under the first image you'll see the wrong href, which is the one of the hidden video:
http://jsfiddle.net/f5pDz/
Thanks!

@Vestride
Copy link
Owner

Thanks @MichiUB, I see the issue now.

Vestride added a commit that referenced this issue Apr 15, 2014
Add jshintrc file. Clean up transition method to get ready for #21.
@xrmx
Copy link
Author

xrmx commented Apr 17, 2014

Works great, thanks @Vestride! Any chance you can cut a minor release please? Thanks @MichiUB for working on the test cases

@MikiMoon
Copy link

Thanks @Vestride @xrmx

Vestride added a commit that referenced this issue Apr 19, 2014
@fnah
Copy link

fnah commented Oct 29, 2014

I encountered this issue to and resolved with adding a css

.concealed {visibility: hidden};

Thank you for this issue resolved, it was puzzling me for a couple hours today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants