Fix possible NPE in 1.17->1.16.4 bedrock at 0 emulation (#821)

FlorianMichael · web-flow · commit c9d57aab8d17 · 2024-07-14T10:10:03.000+02:00
diff --git a/common/src/main/java/com/viaversion/viabackwards/protocol/v1_17to1_16_4/rewriter/BlockItemPacketRewriter1_17.java b/common/src/main/java/com/viaversion/viabackwards/protocol/v1_17to1_16_4/rewriter/BlockItemPacketRewriter1_17.java
@@ -364,10 +364,12 @@ public void register() {
 
             if (ViaBackwards.getConfig().bedrockAtY0()) {
                 final ChunkSection lowestSection = chunk.getSections()[0];
-                final DataPalette blocks = lowestSection.palette(PaletteType.BLOCKS);
-                for (int x = 0; x < 16; x++) {
-                    for (int z = 0; z < 16; z++) {
-                        blocks.setIdAt(x, 0, z, BEDROCK_BLOCK_STATE);
+                if (lowestSection != null) {
+                    final DataPalette blocks = lowestSection.palette(PaletteType.BLOCKS);
+                    for (int x = 0; x < 16; x++) {
+                        for (int z = 0; z < 16; z++) {
+                            blocks.setIdAt(x, 0, z, BEDROCK_BLOCK_STATE);
+                        }
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -364,10 +364,12 @@ public void register() {`
`364`	`364`
`365`	`365`	`if (ViaBackwards.getConfig().bedrockAtY0()) {`
`366`	`366`	`final ChunkSection lowestSection = chunk.getSections()[0];`
`367`		`- final DataPalette blocks = lowestSection.palette(PaletteType.BLOCKS);`
`368`		`- for (int x = 0; x < 16; x++) {`
`369`		`- for (int z = 0; z < 16; z++) {`
`370`		`- blocks.setIdAt(x, 0, z, BEDROCK_BLOCK_STATE);`
	`367`	`+ if (lowestSection != null) {`
	`368`	`+ final DataPalette blocks = lowestSection.palette(PaletteType.BLOCKS);`
	`369`	`+ for (int x = 0; x < 16; x++) {`
	`370`	`+ for (int z = 0; z < 16; z++) {`
	`371`	`+ blocks.setIdAt(x, 0, z, BEDROCK_BLOCK_STATE);`
	`372`	`+ }`
`371`	`373`	`}`
`372`	`374`	`}`
`373`	`375`	`}`