Skip to content

Commit e8637e5

Browse files
committed
Update sound mapping format
VV now includes full sound name mappings, so VB can map them via registry indexes and doesn't need the extra sound file anymore
1 parent 64b454d commit e8637e5

28 files changed

+6
-1393
lines changed

common/src/main/java/com/viaversion/viabackwards/api/data/BackwardsMappingData.java

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import com.viaversion.viaversion.libs.fastutil.ints.Int2ObjectArrayMap;
3535
import com.viaversion.viaversion.libs.fastutil.ints.Int2ObjectMap;
3636
import com.viaversion.viaversion.libs.fastutil.ints.Int2ObjectOpenHashMap;
37-
import com.viaversion.viaversion.util.Key;
3837
import java.util.HashMap;
3938
import java.util.Map;
4039
import java.util.logging.Level;
@@ -45,7 +44,6 @@ public class BackwardsMappingData extends MappingDataBase {
4544

4645
private final Class<? extends Protocol<?, ?, ?, ?>> vvProtocolClass;
4746
protected Int2ObjectMap<MappedItem> backwardsItemMappings;
48-
private Map<String, String> backwardsSoundMappings;
4947
private Map<String, String> entityNames;
5048
private Int2ObjectMap<String> enchantmentNames;
5149

@@ -83,7 +81,6 @@ protected void loadExtras(final CompoundTag data) {
8381

8482
this.entityNames = loadNameByStringMappings(data, "entitynames");
8583
this.enchantmentNames = loadNameByIdMappings(data, "enchantmentnames");
86-
this.backwardsSoundMappings = loadNameByStringMappings(data, "soundnames");
8784
}
8885

8986
private @Nullable Map<String, String> loadNameByStringMappings(final CompoundTag data, final String key) {
@@ -161,10 +158,7 @@ public int getNewAttributeId(final int id) {
161158
}
162159

163160
public @Nullable String getMappedNamedSound(final String id) {
164-
if (backwardsSoundMappings == null) {
165-
return null;
166-
}
167-
return backwardsSoundMappings.get(Key.stripMinecraftNamespace(id));
161+
return getFullSoundMappings().mappedIdentifier(id);
168162
}
169163

170164
public @Nullable String mappedEntityName(final String entityName) {
@@ -187,10 +181,6 @@ public int getNewAttributeId(final int id) {
187181
return backwardsItemMappings;
188182
}
189183

190-
public @Nullable Map<String, String> getBackwardsSoundMappings() {
191-
return backwardsSoundMappings;
192-
}
193-
194184
public @Nullable Class<? extends Protocol<?, ?, ?, ?>> getViaVersionProtocolClass() {
195185
return vvProtocolClass;
196186
}

common/src/main/java/com/viaversion/viabackwards/protocol/v1_19_3to1_19_1/Protocol1_19_3To1_19_1.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919

2020
import com.google.common.base.Preconditions;
2121
import com.viaversion.viabackwards.api.BackwardsProtocol;
22+
import com.viaversion.viabackwards.api.data.BackwardsMappingData;
2223
import com.viaversion.viabackwards.api.rewriters.SoundRewriter;
2324
import com.viaversion.viabackwards.api.rewriters.text.JsonNBTComponentRewriter;
2425
import com.viaversion.viabackwards.protocol.v1_19_1to1_19.Protocol1_19_1To1_19;
25-
import com.viaversion.viabackwards.protocol.v1_19_3to1_19_1.data.BackwardsMappingData1_19_3;
2626
import com.viaversion.viabackwards.protocol.v1_19_3to1_19_1.rewriter.BlockItemPacketRewriter1_19_3;
2727
import com.viaversion.viabackwards.protocol.v1_19_3to1_19_1.rewriter.EntityPacketRewriter1_19_3;
2828
import com.viaversion.viabackwards.protocol.v1_19_3to1_19_1.storage.ChatSessionStorage;
@@ -49,6 +49,7 @@
4949
import com.viaversion.viaversion.libs.gson.JsonElement;
5050
import com.viaversion.viaversion.protocols.base.ClientboundLoginPackets;
5151
import com.viaversion.viaversion.protocols.base.ServerboundLoginPackets;
52+
import com.viaversion.viaversion.protocols.v1_19_1to1_19_3.Protocol1_19_1To1_19_3;
5253
import com.viaversion.viaversion.protocols.v1_19_1to1_19_3.packet.ClientboundPackets1_19_3;
5354
import com.viaversion.viaversion.protocols.v1_19_1to1_19_3.packet.ServerboundPackets1_19_3;
5455
import com.viaversion.viaversion.protocols.v1_19to1_19_1.packet.ClientboundPackets1_19_1;
@@ -68,7 +69,7 @@
6869

6970
public final class Protocol1_19_3To1_19_1 extends BackwardsProtocol<ClientboundPackets1_19_3, ClientboundPackets1_19_1, ServerboundPackets1_19_3, ServerboundPackets1_19_1> {
7071

71-
public static final BackwardsMappingData1_19_3 MAPPINGS = new BackwardsMappingData1_19_3();
72+
public static final BackwardsMappingData MAPPINGS = new BackwardsMappingData("1.19.3", "1.19", Protocol1_19_1To1_19_3.class);
7273
public static final ByteArrayType.OptionalByteArrayType OPTIONAL_SIGNATURE_BYTES_TYPE = new ByteArrayType.OptionalByteArrayType(256);
7374
public static final ByteArrayType SIGNATURE_BYTES_TYPE = new ByteArrayType(256);
7475
private final EntityPacketRewriter1_19_3 entityRewriter = new EntityPacketRewriter1_19_3(this);
@@ -113,7 +114,7 @@ protected void registerPackets() {
113114
return;
114115
}
115116

116-
final int mappedId = MAPPINGS.mappedSound(mappedIdentifier);
117+
final int mappedId = MAPPINGS.getFullSoundMappings().mappedId(mappedIdentifier);
117118
if (mappedId == -1) {
118119
wrapper.cancel();
119120
return;
@@ -401,7 +402,7 @@ public void init(final UserConnection user) {
401402
}
402403

403404
@Override
404-
public BackwardsMappingData1_19_3 getMappingData() {
405+
public BackwardsMappingData getMappingData() {
405406
return MAPPINGS;
406407
}
407408

common/src/main/java/com/viaversion/viabackwards/protocol/v1_19_3to1_19_1/data/BackwardsMappingData1_19_3.java

Lines changed: 0 additions & 53 deletions
This file was deleted.
-893 Bytes
Binary file not shown.
-1.52 KB
Binary file not shown.
-2.63 KB
Binary file not shown.
0 Bytes
Binary file not shown.
-5.86 KB
Binary file not shown.
-872 Bytes
Binary file not shown.
-376 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)