Update container id types

Author: FlorianMichael

common/src/main/java/com/viaversion/viarewind/protocol/v1_8to1_7_6_10/rewriter/BlockItemPacketRewriter1_8.java

@@ -81,11 +81,11 @@ protected void registerPackets() {
 		protocol.registerClientbound(ClientboundPackets1_8.CONTAINER_SET_SLOT, new PacketHandlers() {
 			@Override
 			public void register() {
-				map(Types.UNSIGNED_BYTE); // Window id
+				map(Types.BYTE); // Window id
 				map(Types.SHORT); // Slot
 
 				handler(wrapper -> {
-					final short windowType = wrapper.user().get(InventoryTracker.class).get(wrapper.get(Types.UNSIGNED_BYTE, 0));
+					final short windowType = wrapper.user().get(InventoryTracker.class).get(wrapper.get(Types.BYTE, 0));
 					final short slot = wrapper.get(Types.SHORT, 0);
 					if (windowType == 4) { // Enchantment Table
 						if (slot == 1) {
@@ -100,7 +100,7 @@ public void register() {
 				handler(wrapper -> handleItemToClient(wrapper.user(), wrapper.get(RewindTypes.COMPRESSED_NBT_ITEM, 0)));
 
 				handler(wrapper -> {
-					final short windowId = wrapper.get(Types.UNSIGNED_BYTE, 0);
+					final byte windowId = wrapper.get(Types.BYTE, 0);
 					if (windowId != 0) {
 						return;
 					}
@@ -232,10 +232,10 @@ public void register() {
 		protocol.registerServerbound(ServerboundPackets1_7_2_5.CONTAINER_CLICK, new PacketHandlers() {
 			@Override
 			public void register() {
-				map(Types.BYTE, Types.UNSIGNED_BYTE); // Window id
+				map(Types.BYTE); // Window id
 				map(Types.SHORT); // Slot
 				handler(wrapper -> {
-					final short windowId = wrapper.get(Types.UNSIGNED_BYTE, 0); // Window id
+					final byte windowId = wrapper.get(Types.BYTE, 0); // Window id
 					final short slot = wrapper.get(Types.SHORT, 0);
 
 					final short windowType = wrapper.user().get(InventoryTracker.class).get(windowId);

common/src/main/java/com/viaversion/viarewind/protocol/v1_9to1_8/rewriter/BlockItemPacketRewriter1_9.java

@@ -107,7 +107,7 @@ protected void registerPackets() {
 		});
 
 		protocol.registerClientbound(ClientboundPackets1_9.CONTAINER_SET_SLOT, wrapper -> {
-			final byte windowId = wrapper.passthrough(Types.UNSIGNED_BYTE).byteValue();
+			final byte windowId = wrapper.passthrough(Types.BYTE);
 			final short slot = wrapper.passthrough(Types.SHORT);
 			final Item item = wrapper.passthrough(Types.ITEM1_8);
 
@@ -138,15 +138,15 @@ protected void registerPackets() {
 		protocol.registerServerbound(ServerboundPackets1_8.CONTAINER_CLICK, new PacketHandlers() {
 			@Override
 			public void register() {
-				map(Types.UNSIGNED_BYTE); // Window id
+				map(Types.BYTE); // Window id
 				map(Types.SHORT); // Slot
 				map(Types.BYTE); // Button
 				map(Types.SHORT); // Action number
 				map(Types.BYTE, Types.VAR_INT); // Mode
 				map(Types.ITEM1_8); // Clicked item
 				handler(wrapper -> handleItemToServer(wrapper.user(), wrapper.get(Types.ITEM1_8, 0)));
 				handler(wrapper -> {
-					final short windowId = wrapper.get(Types.UNSIGNED_BYTE, 0);
+					final byte windowId = wrapper.get(Types.BYTE, 0);
 					final String windowType = wrapper.user().get(WindowTracker.class).get(windowId);
 
 					if (windowType != null && windowType.equalsIgnoreCase("minecraft:brewing_stand")) {

common/src/main/java/com/viaversion/viarewind/protocol/v1_9to1_8/storage/WindowTracker.java

@@ -103,7 +103,7 @@ public static void updateBrewingStand(UserConnection user, Item blazePowder, sho
 		Item[] items = user.get(WindowTracker.class).getBrewingItems(windowId);
 		for (int i = 0; i < items.length; i++) {
 			PacketWrapper setSlot = PacketWrapper.create(ClientboundPackets1_8.CONTAINER_SET_SLOT, user);
-			setSlot.write(Types.UNSIGNED_BYTE, windowId);
+			setSlot.write(Types.BYTE, (byte) windowId);
 			setSlot.write(Types.SHORT, (short) i);
 			setSlot.write(Types.ITEM1_8, items[i]);
 			setSlot.scheduleSend(Protocol1_9To1_8.class);