Fix sign update component read types in 1.7<->1.9

Closes #613

Author: FlorianMichael

common/src/main/java/com/viaversion/viarewind/api/type/RewindTypes.java

@@ -28,15 +28,15 @@
 import com.viaversion.viaversion.api.minecraft.item.Item;
 import com.viaversion.viaversion.api.type.Type;
 import com.viaversion.viaversion.api.type.Types;
-import com.viaversion.viaversion.api.type.types.StringType;
+import com.viaversion.viaversion.libs.gson.JsonElement;
 import java.util.List;
 
 /**
  * Safe to use before protocol loading
  */
 public class RewindTypes {
 
-    public static final Type<String> SIGN_STRING = new StringType(384);
+    public static final Type<JsonElement> SIGN_COMPONENT = new SignComponentType();
     public static final Type<int[]> INT_ARRAY = new IntArrayType(); // Integer array with byte as length indicator
 
     public static final Type<BlockPosition> SHORT_POSITION = new PositionVarYType<>(Types.SHORT, value -> (short) value);

common/src/main/java/com/viaversion/viarewind/api/type/SignComponentType.java

@@ -0,0 +1,51 @@
+/*
+ * This file is part of ViaRewind - https://github.com/ViaVersion/ViaRewind
+ * Copyright (C) 2018-2025 ViaVersion and contributors
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+package com.viaversion.viarewind.api.type;
+
+import com.viaversion.viaversion.api.Via;
+import com.viaversion.viaversion.api.type.Type;
+import com.viaversion.viaversion.api.type.types.ComponentType;
+import com.viaversion.viaversion.api.type.types.StringType;
+import com.viaversion.viaversion.libs.gson.JsonElement;
+import com.viaversion.viaversion.libs.gson.JsonParser;
+import com.viaversion.viaversion.libs.gson.JsonSyntaxException;
+import io.netty.buffer.ByteBuf;
+
+public class SignComponentType extends ComponentType {
+
+    public static final Type<String> STRING = new StringType(384);
+
+    @Override
+    public JsonElement read(final ByteBuf buffer) {
+        final String string = STRING.read(buffer);
+        try {
+            return JsonParser.parseString(string);
+        } catch (final JsonSyntaxException e) {
+            if (Via.getManager().isDebug()) {
+                Via.getPlatform().getLogger().severe("Error when trying to parse json: " + string);
+            }
+            throw e;
+        }
+    }
+
+    @Override
+    public void write(final ByteBuf buffer, final JsonElement value) {
+        STRING.write(buffer, value.toString());
+    }
+
+}

common/src/main/java/com/viaversion/viarewind/protocol/v1_9to1_8/rewriter/PlayerPacketRewriter1_9.java

@@ -444,7 +444,7 @@ public void register() {
                 map(Types.BLOCK_POSITION1_8); // Position
                 handler(wrapper -> {
                     for (int i = 0; i < 4; i++) {
-                        final JsonElement json = JsonParser.parseString(wrapper.read(RewindTypes.SIGN_STRING));
+                        final JsonElement json = wrapper.read(RewindTypes.SIGN_COMPONENT);
                         if (!json.isJsonPrimitive()) {
                             throw new IllegalStateException("Invalid sign text: " + StringUtil.forLogging(json));
                         }

gradle.properties

@@ -7,7 +7,7 @@ org.gradle.configuration-cache=true
 project_jvm_version=17
 
 project_group=com.viaversion
-project_version=4.0.9
+project_version=4.0.10-SNAPSHOT
 project_description=ViaVersion addon to allow 1.8.x and 1.7.x clients on newer server versions.
 
 publishing_dev_id=FlorianMichael