Skip to content

Commit 276b9ba

Browse files
Update VV API usage
1 parent 351ff79 commit 276b9ba

File tree

5 files changed

+15
-17
lines changed

5 files changed

+15
-17
lines changed

build-logic/src/main/groovy/vr.base-conventions.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ base {
2222
}
2323

2424
dependencies {
25-
compileOnly "com.viaversion:viaversion:5.2.1"
26-
compileOnly "com.viaversion:viabackwards:5.2.1"
25+
compileOnly "com.viaversion:viaversion:5.2.2-SNAPSHOT"
26+
compileOnly "com.viaversion:viabackwards:5.2.2-SNAPSHOT"
2727
}
2828

2929
publishing {

common/src/main/java/com/viaversion/viarewind/protocol/v1_8to1_7_6_10/rewriter/EntityPacketRewriter1_8.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,8 @@ public void register() {
145145

146146
handler(wrapper -> {
147147
final int entityId = wrapper.get(Types.VAR_INT, 0);
148-
final EntityTypes1_8.EntityType type = EntityTypes1_8.getTypeFromId(wrapper.get(Types.BYTE, 0), true);
148+
int data = wrapper.get(Types.INT, 3);
149+
final EntityTypes1_8.EntityType type = EntityTypes1_8.ObjectType.getEntityType(wrapper.get(Types.BYTE, 0), data);
149150
if (type == null) {
150151
return;
151152
}
@@ -157,8 +158,6 @@ public void register() {
157158
byte pitch = wrapper.get(Types.BYTE, 1);
158159
byte yaw = wrapper.get(Types.BYTE, 2);
159160

160-
int data = wrapper.get(Types.INT, 3);
161-
162161
if (type == EntityTypes1_8.ObjectType.ITEM_FRAME.getType()) {
163162
yaw = switch (yaw) {
164163
case -128 -> {
@@ -267,7 +266,7 @@ public void register() {
267266
handler(wrapper -> {
268267
final short typeId = wrapper.get(Types.UNSIGNED_BYTE, 0);
269268

270-
final EntityTypes1_8.EntityType type = EntityTypes1_8.getTypeFromId(typeId, false);
269+
final EntityTypes1_8.EntityType type = EntityTypes1_8.EntityType.findById(typeId);
271270
if (type == EntityTypes1_8.EntityType.ARMOR_STAND) {
272271
wrapper.cancel();
273272
final int entityId = wrapper.get(Types.VAR_INT, 0);
@@ -698,11 +697,11 @@ public void handleEntityData(EntityDataHandlerEvent event, EntityData entityData
698697

699698
@Override
700699
public EntityTypes1_8.EntityType typeFromId(int type) {
701-
return EntityTypes1_8.getTypeFromId(type, false);
700+
return EntityTypes1_8.EntityType.findById(type);
702701
}
703702

704703
@Override
705-
public EntityTypes1_8.EntityType objectTypeFromId(int type) {
706-
return EntityTypes1_8.getTypeFromId(type, true);
704+
public EntityTypes1_8.EntityType objectTypeFromId(int type, int data) {
705+
return EntityTypes1_8.ObjectType.getEntityType(type, data);
707706
}
708707
}

common/src/main/java/com/viaversion/viarewind/protocol/v1_9to1_8/rewriter/EntityPacketRewriter1_9.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,8 @@ public void register() {
9797
handler(wrapper -> {
9898
final int entityId = wrapper.get(Types.VAR_INT, 0);
9999
final int entityType = wrapper.get(Types.BYTE, 0);
100-
final EntityTypes1_9.EntityType type = EntityTypes1_9.getTypeFromId(entityType, true);
100+
int data = wrapper.get(Types.INT, 0);
101+
final EntityTypes1_9.EntityType type = EntityTypes1_9.ObjectType.getEntityType(entityType, data);
101102

102103
// Cancel new entities which can't be handled properly
103104
if (type == null || type == EntityTypes1_9.EntityType.AREA_EFFECT_CLOUD || type == EntityTypes1_9.EntityType.SPECTRAL_ARROW || type == EntityTypes1_9.EntityType.DRAGON_FIREBALL) {
@@ -115,8 +116,6 @@ public void register() {
115116
wrapper.set(Types.INT, 1, y);
116117
}
117118

118-
int data = wrapper.get(Types.INT, 3);
119-
120119
if (type.isOrHasParent(EntityTypes1_9.EntityType.ARROW) && data != 0) {
121120
wrapper.set(Types.INT, 3, --data);
122121
}
@@ -623,11 +622,11 @@ private void handleEntityData(EntityDataHandlerEvent event, EntityData entityDat
623622

624623
@Override
625624
public EntityTypes1_9.EntityType typeFromId(int type) {
626-
return EntityTypes1_9.getTypeFromId(type, false);
625+
return EntityTypes1_9.EntityType.findById(type);
627626
}
628627

629628
@Override
630-
public EntityTypes1_9.EntityType objectTypeFromId(int type) {
631-
return EntityTypes1_9.getTypeFromId(type, true);
629+
public EntityTypes1_9.EntityType objectTypeFromId(int type, int data) {
630+
return EntityTypes1_9.ObjectType.getEntityType(type, data);
632631
}
633632
}

fabric/src/main/resources/fabric.mod.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
},
2525
"depends": {
2626
"viafabric": ">=0.4.14",
27-
"viabackwards": ">=5.2.1"
27+
"viabackwards": ">=5.2.2-SNAPSHOT"
2828
},
2929
"custom": {
3030
"modmenu:api": true,

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ org.gradle.parallel=true
44

55
# project
66
maven_group=com.viaversion
7-
maven_version=4.0.5
7+
maven_version=4.0.6-SNAPSHOT
88
maven_description=ViaBackwards addon to allow 1.8.x and 1.7.x clients on newer server versions.
99

1010
# Smile emoji

0 commit comments

Comments
 (0)