check payments resources against api reference.

docs/v4-upgrade.md

@@ -0,0 +1,21 @@
+# Notable changes included in v4
+
+## Breaking changes
+
+- `idempotency` package has moved from the `mollie` directory to the `pkg` directory.
+- `pagination` package has moved from the`mollie` directory to the `pkg` directory.
+- `connect` package has moved from the `mollie` directory to the `pkg` directory.
+- root namespace is not `github.com/VictorAvelar/mollie-api-go/v4/`.
+- Changes for payments resource
+  - Added `CreatePayment` type to use when creating a payment.
+  - Added `UpdatePayment` type to use when updating a payment.
+  - Ensured `Payment` object (used for read operations) contains all the available fields.
+  - Created types specific for fields that are conditional given the payment values, both to create new payments and to list existing payments.
+
+## Other changes
+
+- `testify.Suite` was removed from all testing.
+- Improvements for devcontainer files
+- Major versions of multiple github actions updated
+- Base `Dockerfile` using Go 1.22.x
+- Tests related to payments were update to use the new types.

mollie/captures.go

@@ -7,6 +7,15 @@ import (
 	"time"
 )
 
+// CaptureMode describes the mode of a capture.
+type CaptureMode string
+
+// CaptureMode possible values.
+const (
+	AutomaticCapture CaptureMode = "automatic"
+	ManualCapture    CaptureMode = "manual"
+)
+
 // CapturesService operates over captures resource.
 type CapturesService service
 

mollie/common_types.go

@@ -321,6 +321,15 @@ const (
 	TestMode Mode = "test"
 )
 
+// IncludeValue is a valid value for the Include query string parameter.
+type IncludeValue string
+
+// Supported Include values.
+const (
+	IncludeQrCode           IncludeValue = "details.qrCode"
+	IncludeRemainderDetails IncludeValue = "details.remainderDetails"
+)
+
 // EmbedValue describes the valid value of embed query string.
 type EmbedValue string
 
@@ -330,6 +339,7 @@ const (
 	EmbedRefund      EmbedValue = "refunds"
 	EmbedShipments   EmbedValue = "shipments"
 	EmbedChargebacks EmbedValue = "chargebacks"
+	EmbedCaptures    EmbedValue = "captures"
 )
 
 // Rate describes service rates, further divided into fixed and percentage costs.

mollie/customers.go

@@ -170,7 +170,7 @@ func (cs *CustomersService) GetPayments(ctx context.Context, id string, options
 // CreatePayment creates a payment for the customer.
 //
 // See: https://docs.mollie.com/reference/v2/customers-api/create-customer-payment
-func (cs *CustomersService) CreatePayment(ctx context.Context, id string, p Payment) (
+func (cs *CustomersService) CreatePayment(ctx context.Context, id string, p CreatePayment) (
 	res *Response,
 	pp *Payment,
 	err error,

mollie/customers_test.go

@@ -621,7 +621,7 @@ func TestCustomerService_CreatePayment(t *testing.T) {
 	type args struct {
 		ctx      context.Context
 		customer string
-		payment  Payment
+		payment  CreatePayment
 	}
 
 	cases := []struct {
@@ -637,7 +637,11 @@ func TestCustomerService_CreatePayment(t *testing.T) {
 			args{
 				context.Background(),
 				"cst_kEn1PlbGa",
-				Payment{TestMode: true},
+				CreatePayment{
+					CreatePaymentAccessTokenFields: CreatePaymentAccessTokenFields{
+						Testmode: true,
+					},
+				},
 			},
 			false,
 			nil,
@@ -657,7 +661,11 @@ func TestCustomerService_CreatePayment(t *testing.T) {
 			args{
 				context.Background(),
 				"cst_kEn1PlbGa",
-				Payment{TestMode: true},
+				CreatePayment{
+					CreatePaymentAccessTokenFields: CreatePaymentAccessTokenFields{
+						Testmode: true,
+					},
+				},
 			},
 			true,
 			fmt.Errorf("500 Internal Server Error: An internal server error occurred while processing your request."),
@@ -669,7 +677,11 @@ func TestCustomerService_CreatePayment(t *testing.T) {
 			args{
 				context.Background(),
 				"cst_kEn1PlbGa",
-				Payment{TestMode: true},
+				CreatePayment{
+					CreatePaymentAccessTokenFields: CreatePaymentAccessTokenFields{
+						Testmode: true,
+					},
+				},
 			},
 			true,
 			fmt.Errorf("invalid character 'h' looking for beginning of object key string"),
@@ -681,7 +693,11 @@ func TestCustomerService_CreatePayment(t *testing.T) {
 			args{
 				context.Background(),
 				"cst_kEn1PlbGa",
-				Payment{TestMode: true},
+				CreatePayment{
+					CreatePaymentAccessTokenFields: CreatePaymentAccessTokenFields{
+						Testmode: true,
+					},
+				},
 			},
 			true,
 			errBadBaseURL,