Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow vmagent_service_args to have multiple values for same flag #58

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

ym
Copy link
Contributor

@ym ym commented Mar 23, 2024

This PR will make multiple remoteWrite.url possible without breaking the current configuration format.

vmagent_service_args:
  'remoteWrite.url':
    - '{{ vmagent_remote_write_host_0 }}/api/v1/write'
    - '{{ vmagent_remote_write_host_1 }}/api/v1/write'
  'promscrape.config': '{{ vmagent_config_dir }}/config.yml'
  'remoteWrite.tmpDataPath': /tmp/vmagent
  'remoteWrite.streamAggr.config': '{{ vmagent_config_dir }}/aggregation.yml'

@ym ym requested a review from zekker6 as a code owner March 23, 2024 21:08
@zekker6
Copy link
Collaborator

zekker6 commented Mar 25, 2024

Hello @ym, thank you for the PR!

@zekker6 zekker6 merged commit cca640e into VictoriaMetrics:master Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants