Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip trailing whitespace in templates #1379

Merged
merged 13 commits into from
Jun 21, 2022
Merged

Strip trailing whitespace in templates #1379

merged 13 commits into from
Jun 21, 2022

Commits on Jun 2, 2022

  1. Strip trailing newlines in templates

    @camertron
    camertron committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    b6e3135 View commit details
    Browse the repository at this point in the history

  2. Use rstrip so only trailing whitespace is trimmed

    @camertron
    camertron committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    4fcf3b2 View commit details
    Browse the repository at this point in the history

  3. Add changelog entry

    @camertron
    camertron committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    9725018 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Add test demonstrating trailing newline behavior

    @camertron
    camertron committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    b280714 View commit details
    Browse the repository at this point in the history

  2. Use config option

    @camertron
    camertron committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    a271a5b View commit details
    Browse the repository at this point in the history

  3. Merge upstream changes

    @camertron
    camertron committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    353f80f View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Fix linting issues

    @camertron
    camertron committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    7947302 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Update lib/view_component/base.rb 

    Use a default value for the boolean flag so you can simply call `strip_trailing_newlines` in your component.

Co-authored-by: Joel Hawksley <joel@hawksley.org>
    @camertron @joelhawksley
    camertron and joelhawksley authored Jun 16, 2022
    Configuration menu
    Copy the full SHA
    7dc890e View commit details
    Browse the repository at this point in the history

  2. Add additional docs; rename to strip_trailing_whitespace

    @camertron
    camertron committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    56d708d View commit details
    Browse the repository at this point in the history

  3. Merging upstream changes

    @camertron
    camertron committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    90a6a82 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Fence code blocks in base.rb

    @camertron
    camertron committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    5854858 View commit details
    Browse the repository at this point in the history

  2. Move trailing whitespace docs to templates docs

    @camertron
    camertron committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    d6d1041 View commit details
    Browse the repository at this point in the history

  3. Merging upstream changes

    @camertron
    camertron committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    b303be8 View commit details
    Browse the repository at this point in the history