Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: banner responsive in mobile devices #128

Merged

Conversation

TandinDev
Copy link
Contributor

What does this PR do?
This PR fixes the banner responsive issue in the mobile devices.

Related Issue(s)
List any related issues or tasks that this PR addresses.

Changes
Bugfixes includes:
i/ Banner responsive issue (fixed)
ii/ ScrollBar visible in while scrolling ( fixed)
iii/ First button having margin-left-3 (fixed)

Screenshots or GIFs (if applicable)
ezgif com-video-to-gif

Checklist

  • [*] I have read and followed the contributing guidelines.
  • [*] My code follows the project's coding style and conventions.
  • [*] I have added unit tests (if applicable) to ensure the code works as expected.
  • [*] I have updated the project documentation (if necessary).

Additional Comments
I had to hide the scroll bar using css because tailwind don't provide this feature yet.

By submitting this PR, I confirm that:

  • [*] I have reviewed my code and believe it is ready for merging.
  • [*] I understand that this PR may be subject to review and changes.
  • [*] I agree to abide by the code of conduct and contributing guidelines of this project.

@netlify
Copy link

netlify bot commented Oct 8, 2023

👷 Deploy request for snapgrid pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e23fec1

@netlify
Copy link

netlify bot commented Oct 8, 2023

Deploy Preview for stalwart-begonia-80f542 failed.

Name Link
🔨 Latest commit e23fec1
🔍 Latest deploy log https://app.netlify.com/sites/stalwart-begonia-80f542/deploys/6522a90e9c323d0008de3575

@Vijaykv5
Copy link
Owner

Vijaykv5 commented Oct 8, 2023

Thanks for contributing 🚀

@Vijaykv5 Vijaykv5 merged commit f0ad6d1 into Vijaykv5:master Oct 8, 2023
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants