This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Transcript integration #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmseyd
added a commit
that referenced
this pull request
Apr 26, 2020
Transcript integration (#19) * integrate Derek's transcription script with Lambda * create tests and make functions more consistent debugging print statements -_- exclude jobName as it caused errors get debug info from Lamba instance don't use URLEncodedKey, it's empty create intermediate transcription bucket & lambda handler existing: true on transcription bucket enable rw permissions on transcription bucket bad indentation :( make the waitgroup actually wait copy json instead of down/upload change to base64 and cut extra code clean up give delete permissions in transcription bucket disable delete, it times out costing us $$$ it works, we can worry about temp files later
malcolmseyd
added a commit
that referenced
this pull request
Apr 26, 2020
* integrate Derek's transcription script with Lambda * create tests and make functions more consistent debugging print statements -_- exclude jobName as it caused errors get debug info from Lamba instance don't use URLEncodedKey, it's empty create intermediate transcription bucket & lambda handler existing: true on transcription bucket enable rw permissions on transcription bucket bad indentation :( make the waitgroup actually wait copy json instead of down/upload change to base64 and cut extra code clean up give delete permissions in transcription bucket disable delete, it times out costing us $$$ it works, we can worry about temp files later
malcolmseyd
added a commit
that referenced
this pull request
Apr 28, 2020
* integrate Derek's transcription script with Lambda * create tests and make functions more consistent debugging print statements -_- exclude jobName as it caused errors get debug info from Lamba instance don't use URLEncodedKey, it's empty create intermediate transcription bucket & lambda handler existing: true on transcription bucket enable rw permissions on transcription bucket bad indentation :( make the waitgroup actually wait copy json instead of down/upload change to base64 and cut extra code clean up give delete permissions in transcription bucket disable delete, it times out costing us $$$ it works, we can worry about temp files later
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derek's transcript job script has been fully integrated into the convert-audio function (which we might want to rename). The functions do not run in parallel and the output bucket is hardcoded.