Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed BG image and host #11

Merged
merged 2 commits into from
Oct 23, 2017
Merged

Changed BG image and host #11

merged 2 commits into from
Oct 23, 2017

Conversation

dhd5076
Copy link
Contributor

@dhd5076 dhd5076 commented Oct 22, 2017

Fixes Issue #10

@Vild
Copy link
Owner

Vild commented Oct 22, 2017

Hi, thanks for the PR and being interested in this project :)
I forgot that I discontinued that domain, so thanks for fixing that, but could you change the link to reference a 1920x1080 instead of an 1920x1200 image?
As the default Xephyr instance launches at this resolution.

@Vild Vild self-assigned this Oct 22, 2017
@dhd5076
Copy link
Contributor Author

dhd5076 commented Oct 22, 2017

Can do, I'll make another commit, but would it better to add a local image? It shouldn't take much to just load locally and that way it would work offline as well.

@Vild
Copy link
Owner

Vild commented Oct 22, 2017

True, but I don't really like adding images and binary files to git repos as they really increase the size of the repo. This is why I give feh a URL instead.

@dhd5076
Copy link
Contributor Author

dhd5076 commented Oct 22, 2017

All set

@Vild Vild merged commit 4bcc512 into Vild:master Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Vild Vild

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhd5076 @Vild