Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings modifications are applied without pressing the “Save” button #12

Closed
Tahhirah opened this issue May 8, 2019 · 0 comments
Closed

Settings modifications are applied without pressing the “Save” button #12

Tahhirah opened this issue May 8, 2019 · 0 comments
Labels
bug Something isn't working
Milestone
1.0.1

Comments

@Tahhirah
Copy link
Collaborator

Tahhirah commented May 8, 2019

  1. Access "Setting"
  2. Make some modifications (do not press Save)
  • Settings modifications are applied without pressing the “Save” button
@Tahhirah Tahhirah added the bug Something isn't working label May 8, 2019
@Vince-F Vince-F added this to the 1.0.1 milestone May 8, 2019
Vince-F added a commit that referenced this issue May 8, 2019
@Vince-F
Merge pull request #24 from Vince-F/fix/12-setting-persisted-without-…
8f3a10a 
…save

fixes #12 don't use settings object for setting component but duplica…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
2 participants
@Vince-F @Tahhirah