Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create time log window presents scroll bar when the error messages are present #15

Closed
Tahhirah opened this issue May 8, 2019 · 1 comment
Closed

Create time log window presents scroll bar when the error messages are present #15

Tahhirah opened this issue May 8, 2019 · 1 comment
Labels
bug Something isn't working
Milestone
1.0.1

Comments

@Tahhirah
Copy link
Collaborator

Tahhirah commented May 8, 2019

  1. Go to Create time log
  2. Do not insert any data
  3. Press "Create" (in order to have error messages
  • Create time log window presents scroll bar when the error messages are present

scroll bar
@Tahhirah Tahhirah added the bug Something isn't working label May 8, 2019
@Vince-F Vince-F added this to the 1.0.1 milestone May 8, 2019
@Vince-F
Copy link
Owner

Vince-F commented May 8, 2019

Bug of the underlying Angular component angular/components#4580
They support only one line of text, reducing error so it fits in one line (might have an issue when translations are here and it is longer)

Vince-F added a commit that referenced this issue May 8, 2019
@Vince-F
Merge pull request #23 from Vince-F/fix/15-scrollbar-in-modal-on-error
bae9ad6 
fixes #15, make error fit on one line
@Vince-F Vince-F mentioned this issue May 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
2 participants
@Vince-F @Tahhirah