-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more than two sides for Sidebar, Speech and Loading Screens. #921
Open
CCHyper
wants to merge
13
commits into
Vinifera-Developers:develop
Choose a base branch
from
CCHyper:feature/new-side-support
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for more than two sides for Sidebar, Speech and Loading Screens. #921
CCHyper
wants to merge
13
commits into
Vinifera-Developers:develop
from
CCHyper:feature/new-side-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment is automaticly generated by Nightly.link and allows non-registered users to get download the artifacts for this pull request. These links are also updated when the pull request is pushed to. |
d4caede
to
bd2ffcb
Compare
48cd2ea
to
b789478
Compare
44d9035
to
4dbdb23
Compare
d649039
to
5a6cb19
Compare
52f41b5
to
0bcb341
Compare
9829680
to
07fcc9f
Compare
8a846d9
to
f302184
Compare
f302184
to
bd43caa
Compare
…ainst the unmodified status on the INIs.
…oading screen when playing the campaign.
bd43caa
to
4b72b0a
Compare
According to @E1Elite, loading screens for additional sides (e.g. Scenario override works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #218, Closes #309, Closes #294, Closes #665, Closes #922
This pull request implements support/bug-fixes for the following;
[Basic]
->SidebarSide=<SideType>
(campaign scenarios only).NOTES:
Loading Screens;
The original game used
LOAD###C
andLOAD###D
for the GDI loading screens, andLOAD###A
andLOAD###B
for the NOD loading screens. This behavior is retained, and all further sides will use the correct suffixes (e.g.LOAD###E
andLOAD###F
for the 3rd side, etc).Custom Loading Screens;
You can now override the loading screen for a specific scenario. (There is a limit of 32 characters for the filename). These are to be defined under the
[Basic]
section of a scenario.LS400BkgdName=
,LS480BkgdName=
,LS600BkgdName=
, for example;LS400BkgdName=LS400GDI1A.PCX
In addition to this, you can also set the position of the text on the loading screen (only if a custom loading screen has been defined);
LS400TextLoc=
,LS480TextLoc=
,LS600TextLoc=
. Each is in the format ofLS400TextLoc=X,Y
.