Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more than two sides for Sidebar, Speech and Loading Screens. #921

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

CCHyper
Copy link
Contributor

@CCHyper CCHyper commented Nov 25, 2022

Closes #218, Closes #309, Closes #294, Closes #665, Closes #922

This pull request implements support/bug-fixes for the following;

  • Removes the limit of only two sides allowed to have unique sidebar and speech assets.
  • Removes the limit of only two sides allowed to have unique loading screens.
  • Fixes a bug where the loading screen text was inconsistent, it is now centered in the text box.
  • Ability to override the player's sidebar graphics. [Basic] -> SidebarSide=<SideType> (campaign scenarios only).
  • Custom loading screens can now be defined per scenario, for each supported resolution.

NOTES:

Loading Screens;
The original game used LOAD###C and LOAD###D for the GDI loading screens, and LOAD###A and LOAD###B for the NOD loading screens. This behavior is retained, and all further sides will use the correct suffixes (e.g. LOAD###E and LOAD###F for the 3rd side, etc).

Custom Loading Screens;
You can now override the loading screen for a specific scenario. (There is a limit of 32 characters for the filename). These are to be defined under the [Basic] section of a scenario.
LS400BkgdName=, LS480BkgdName=, LS600BkgdName=, for example; LS400BkgdName=LS400GDI1A.PCX

In addition to this, you can also set the position of the text on the loading screen (only if a custom loading screen has been defined);
LS400TextLoc=, LS480TextLoc=, LS600TextLoc=. Each is in the format of LS400TextLoc=X,Y.

@CCHyper CCHyper added new-feature New feature or request. enhancement Enhancement to original behaviour. labels Nov 25, 2022
@CCHyper CCHyper requested a review from a team November 25, 2022 14:13
@github-actions
Copy link

github-actions bot commented Nov 25, 2022

This comment is automaticly generated by Nightly.link and allows non-registered users to get download the artifacts for this pull request.

These links are also updated when the pull request is pushed to.

@CCHyper CCHyper force-pushed the feature/new-side-support branch 3 times, most recently from d4caede to bd2ffcb Compare December 6, 2022 03:49
@CCHyper CCHyper force-pushed the develop branch 3 times, most recently from 48cd2ea to b789478 Compare December 22, 2022 08:32
@CCHyper CCHyper force-pushed the feature/new-side-support branch 2 times, most recently from 44d9035 to 4dbdb23 Compare February 22, 2023 19:56
@CCHyper CCHyper force-pushed the develop branch 3 times, most recently from d649039 to 5a6cb19 Compare February 24, 2023 11:01
@CCHyper CCHyper force-pushed the feature/new-side-support branch 3 times, most recently from 52f41b5 to 0bcb341 Compare March 17, 2023 12:48
@CCHyper CCHyper added this to the TS-Patches milestone Mar 17, 2023
@CCHyper CCHyper force-pushed the feature/new-side-support branch 4 times, most recently from 9829680 to 07fcc9f Compare March 20, 2023 02:38
@CCHyper CCHyper self-assigned this Mar 28, 2023
@Crimsonum
Copy link

According to @E1Elite, loading screens for additional sides (e.g. LOAD###E) do not work, the game defaults to the GDI loading screens for such sides.

Scenario override works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment