Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all hard coded directory separators "/" "\\" #28

Closed
Woland2k opened this issue Oct 19, 2017 · 0 comments
Closed

Replace all hard coded directory separators "/" "\\" #28

Woland2k opened this issue Oct 19, 2017 · 0 comments
Assignees
@tatarincev
Labels
release blocker

Comments

@Woland2k
Copy link
Contributor

Instead of using hard coded values, use either Path.Combine or Path.DirectorySeparatorChar
Woland2k added a commit that referenced this issue Oct 19, 2017
@Woland2k
Fix to issue #28
7687394
@asvishnyakov asvishnyakov mentioned this issue Nov 16, 2017
Closed
ksavosteev pushed a commit that referenced this issue Feb 28, 2018
#28 wishlist add product fixed, small optimizations
4c4cb51
ksavosteev pushed a commit that referenced this issue Feb 28, 2018
#28 fixed typos, provided some comments, endpoing name changes
bb2033a
ksavosteev pushed a commit that referenced this issue Mar 1, 2018
#28 removed storefrontapi/lists/contains route
71a6e80
ksavosteev pushed a commit that referenced this issue Mar 12, 2018
#28 wishlist builder service
2ea76e9
ksavosteev pushed a commit that referenced this issue Mar 13, 2018
#28 Lists API refactoring (wishlist class introduced, all api methods…
209e5eb 
… now take 'type' property)
ksavosteev pushed a commit that referenced this issue Mar 13, 2018
#28 PR feedback fixes
5bf2ebc
ksavosteev pushed a commit that referenced this issue Mar 13, 2018
#28 caching for search results added
0ba92ef
ksavosteev pushed a commit that referenced this issue Mar 14, 2018
#28 added wishlist limit, litited deletion only for customer's list ,…
13df402 
… further refactoring
tatarincev pushed a commit that referenced this issue Mar 19, 2018
@tatarincev
Dev wishlists search and create (#84)
1225686 
* [draft] Add,search,delete,merge lists functionality

* #28 wishlist builder service

* #28 Lists API refactoring (wishlist class introduced, all api methods now take 'type' property)

* #28 PR feedback fixes

* #28 caching for search results added

* #28  added wishlist limit, litited deletion only for customer's list , further refactoring

* Fix for merge cart with the same user  - excule user from list of objets to reset  primary keys to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tatarincev tatarincev

Labels
release blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Woland2k @tatarincev