Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt to 1.7.1 #195

Merged
merged 7 commits into from
Jul 14, 2022
Merged

Conversation

scala-steward
Copy link
Contributor

Updates org.scala-sbt:sbt from 1.6.2 to 1.7.1.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-sbt", artifactId = "sbt" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@PawelLipski
Copy link
Collaborator

☹️

@LukaszKontowski
Copy link
Contributor

Since sbt 1.7.0 "a concrete version such as ++ 3.0.1 requires exact version to be present in crossScalaVersion" - see release notes here: https://github.com/sbt/sbt/releases/tag/v1.7.0

build.sbt Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
@LukaszKontowski
Copy link
Contributor

LukaszKontowski commented Jul 13, 2022

Current error:
[error] bad option: '-Ymacro-annotations'
is connected to the fact that when sbt "++ 2.12.13 test" is invoked - for some reason compilation starts both for scala 2.12 and for scala 2.13 - e.g. https://github.com/VirtusLab/akka-serialization-helper/runs/7319169873?check_suite_focus=true

And that's why the error occurs - it is connected to https://github.com/VirtusLab/akka-serialization-helper/blob/main/build.sbt#L116 - where after invoking sbt "++ 2.12.13 test" there are two compilations ruuning - for 2.12 and 2.13 scala versions (scalaVersionAxis.value.map gets invoked two times - one for 2.13 and one for 2.12)

And this is for sbt 1.7.x - for 1.6.x builds - sbt "++ 2.12.13 test" would invoke only one compilation for scala 2.12

@LukaszKontowski
Copy link
Contributor

LukaszKontowski commented Jul 13, 2022

The solution for mentioned error ([error] bad option: '-Ymacro-annotations') is here: 20ef8e1

  • checking by scalaVersionAxis.value

has been replaced by

scalaVersionAxis.value.map {
case "2.13" => Seq(scalaReflect % scalaVersion213)
case "2.12" =>
CrossVersion
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat indeed!

@LukaszKontowski LukaszKontowski merged commit edd2cfd into VirtusLab:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants