Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable some scalafmt rewrites #171

Merged
merged 4 commits into from
Oct 7, 2021

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Sep 30, 2021

This enables

  • RedundantBraces
  • RedundantParens
  • SortModifiers

I'm not too happy with how RedundantBraces handles try, finally, and yield blocks, so I'm not sure we want to merge this right now (maybe we can enable only the two other rules first). (a few // format: off or manual reflowing of the code just do)

@alexarchambault alexarchambault marked this pull request as ready for review October 6, 2021 17:07
@alexarchambault
Copy link
Contributor Author

Not sure DisableSyntax.noIsInstanceOf = true work fine. There's still one here for example.

@alexarchambault alexarchambault merged commit 1f56dfd into VirtusLab:master Oct 7, 2021
@alexarchambault alexarchambault deleted the scalafmt-rewrites branch October 7, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant