Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare scala-cli to handle Scala 3 Native correctly #527

Merged
merged 14 commits into from
Jan 18, 2022

Conversation

jchyb
Copy link
Contributor

@jchyb jchyb commented Jan 5, 2022

This includes a couple of changes:

  • Similarly to a regular Scala or Scala.js, a scala3-library is fetched if Scala 3 is used (here called scala3lib for Native)
  • Scala Native compatibility checks were updated - now everything is checked against both Scala language version and Scala Native version. The error message was also adjusted.
  • If a snapshot version of scala-native-cli is used, now a Sonatype snapshot repository should be also checked for it. This is something I did not take into consideration before, and while up to this point no snapshot version of scala-native-cli was released, this is more of a future-proof than necessary change.

I was testing it with a locally published scala-native-cli 0.4.3-SNAPSHOT and scala-native-cli 0.4.3-RC2 should be released soon. On that release I'll add additional Scala 3 Native integration tests to the CI (either in this PR or separately, however will be more convenient)

@jchyb jchyb force-pushed the scala-3-native branch 4 times, most recently from 9ab0935 to 98728c0 Compare January 7, 2022 16:06
@jchyb jchyb marked this pull request as draft January 11, 2022 09:50
@jchyb
Copy link
Contributor Author

jchyb commented Jan 11, 2022

I want to add some tests, I will add them and mark this PR as ready after the scala-native 0.4.2-RC2 release

@WojciechMazur
Copy link
Contributor

WojciechMazur commented Jan 11, 2022

Scala Native CLI artifacts for 0.4.3-RC2 were published today

@jchyb jchyb marked this pull request as ready for review January 12, 2022 12:47
Copy link
Member

@romanowski romanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one nit I found but this is not that important.

I think the documentation needs to be updated since e.g. our Scala Native guide mentions Scala versions.

modules/build/src/main/scala/scala/build/Artifacts.scala Outdated Show resolved Hide resolved
@romanowski romanowski merged commit 1481aa1 into VirtusLab:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants