-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare scala-cli to handle Scala 3 Native correctly #527
Conversation
modules/build/src/main/scala/scala/build/options/SNNumeralVersion.scala
Outdated
Show resolved
Hide resolved
modules/build/src/main/scala/scala/build/options/ScalaNativeOptions.scala
Outdated
Show resolved
Hide resolved
9ab0935
to
98728c0
Compare
I want to add some tests, I will add them and mark this PR as ready after the scala-native 0.4.2-RC2 release |
Scala Native CLI artifacts for 0.4.3-RC2 were published today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one nit I found but this is not that important.
I think the documentation needs to be updated since e.g. our Scala Native guide mentions Scala versions.
This includes a couple of changes:
scala3lib
for Native)I was testing it with a locally published scala-native-cli 0.4.3-SNAPSHOT and scala-native-cli 0.4.3-RC2 should be released soon. On that release I'll add additional Scala 3 Native integration tests to the CI (either in this PR or separately, however will be more convenient)