Don't compute "hash data" for options that are not used by Bloop #648
Conversation
Make that more explicit via `notForBloopOptions: PostBuildOptions`.
alexarchambault
force-pushed
the
not-for-bloop-build-options
branch
from
dd0f00a
to
f946e6f
Compare
| @@ -38,8 +38,7 @@ final case class BuildOptions( | |||
| internal: InternalOptions = InternalOptions(), | |||
| mainClass: Option[String] = None, | |||
| testOptions: TestOptions = TestOptions(), | |||
| packageOptions: PackageOptions = PackageOptions(), | |||
| replOptions: ReplOptions = ReplOptions() | |||
| notForBloopOptions: PostBuildOptions = PostBuildOptions() | |||
There was a problem hiding this comment.
I think we should call it postBuildOptions
There was a problem hiding this comment.
Or maybe rename PostBuildOptions to NotForBloopOptions ? I wanted to make it clear that it shouldn't be used when generating the Bloop config for example.
There was a problem hiding this comment.
It is strange that BuildOptions contains PostBuild / NotForBloop. maybe we should Refactor it at some point so we have an Option object that contains BuildOptions (ones that bloop cares for), runtime options (like main class, tests, repl things), package options etc.
There was a problem hiding this comment.
That's what I wanted to do initially, something like
final case class AllBuildOptions(
buildOptions: BuildOptions = BuildOptions(),
postBuildOption: PostBuildOptions = PostBuildOptions()
)I just fear it'll touch many-many files in the codebase.
There was a problem hiding this comment.
ok, we can live now with notForBloopOptions and refactor option to AlLBuildOption at some point
…tusLab#648) Make that more explicit via `notForBloopOptions: PostBuildOptions`.
This PR makes that more explicit via
notForBloopOptions: PostBuildOptionsinBuildOptions.This hash is only used to make Bloop directories unique, so it doesn't need to take package or repl options into account.