Track the starting and ending position of each token. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This opens the door for improving the AST in the future, storing the starting and ending position within the source code for each node in the AST. Also improves the way in the line number associated to each rule is computed, until know the line number for rule was the line number where the "rule" keyword was found, but now it takes in to account that a rule definition may start with some modifiers located some lines before the "rule" keyword.
guspascual
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens the door for improving the AST in the future, storing the starting and ending position within the source code for each node in the AST. Also improves the way in the line number associated to each rule is computed, until know the line number for rule was the line number where the "rule" keyword was found, but now it takes in to account that a rule definition may start with some modifiers located some lines before the "rule" keyword.