Pass build parameters correctly, enable dex and macho modules #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #254
According to the discussion under this PR, build parameters should be added via the
setup.cfg
file.Enabling modules
cuckoo
andmagic
requires the build machine to install additional libraries. To avoid major CI changes, keep them disabled.The
openssl
part will be automatically enabled based on whether there is openssl in the build environment, so there is no need to configure and enable it.If oepnssl is manually configured and enabled, an error will occur when building the
-macosx_universal2
wheel. Because the macos build environment cannot provide the arm version of openssl dependent libraries. Due to parameter passing issues in previous builds, the-macosx_universal2
version of the package did not enable openssl and did not include the hash module.I kept the
-macosx_universal2
version of the build, but it still doesn't have openssl enabled, and it still doesn't include the hash module. This may cause confusion for arm64 macos users, so according to #253 , a build of sdist was added. This allows advanced users to use local build installations if necessary.In addition, according to the instructions in the CI log:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
I upgraded the version of
docker/setup-qemu-action
.