Fix case sensitive checks. #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using pe.import_rva() or pe.delayed_import_rva() they were using case sensitive checks while other import/export functions were case insensitive. The import_rva() and delayed_import_rva() were added in 4.3.0 so I think they aren't heavily used yet and we can fix them to be consistent now. Noticed by: Ronnie Salomonsen
plusvic
approved these changes
Apr 3, 2023
plusvic
pushed a commit
that referenced
this pull request
Apr 12, 2023
* Fix case sensitive checks. When using pe.import_rva() or pe.delayed_import_rva() they were using case sensitive checks while other import/export functions were case insensitive. The import_rva() and delayed_import_rva() were added in 4.3.0 so I think they aren't heavily used yet and we can fix them to be consistent now. Noticed by: Ronnie Salomonsen * Fix typo in docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using pe.import_rva() or pe.delayed_import_rva() they were using case sensitive checks while other import/export functions were case insensitive.
The import_rva() and delayed_import_rva() were added in 4.3.0 so I think they aren't heavily used yet and we can fix them to be consistent now.
Noticed by: Ronnie Salomonsen