Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] cloneDeep should be replaced to cloneDeepSpec from vutils-extension when cloning vchart spec #1422

Closed
zamhown opened this issue Apr 1, 2024 · 0 comments · Fixed by #1446
Closed

[Bug] cloneDeep should be replaced to cloneDeepSpec from vutils-extension when cloning vchart spec #1422

zamhown opened this issue Apr 1, 2024 · 0 comments · Fixed by #1446
Assignees
@fangsmile

Comments

@zamhown
Copy link
Member

zamhown commented Apr 1, 2024

img_v3_029h_f1317381-dc36-4378-86b0-d060697b603g

用 cloneDeep 深拷贝 vchart spec 可能会丢失 spec 里的特殊对象，如 dom 对象。需要改为 vutils-extension 里的 cloneDeepSpec 方法。

关联 issue：VisActor/VChart#2514
@fangsmile fangsmile self-assigned this Apr 2, 2024
fangsmile added a commit that referenced this issue Apr 7, 2024
@fangsmile
fix: chart spec clone filtered dom problem #1422
917b4cb
@fangsmile fangsmile linked a pull request Apr 7, 2024 that will close this issue
1422 clone deep spec vutils extension #1446
Merged
21 tasks
@github-actions github-actions bot mentioned this issue Apr 10, 2024
Merged
fangsmile added a commit that referenced this issue Apr 12, 2024
@fangsmile
fix: chartSpec clone #1422
30ee82c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fangsmile fangsmile

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1422 clone deep spec vutils extension VisActor/VTable
2 participants
@fangsmile @zamhown