Add possibility to set log level in instance #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejavier
force-pushed
the
log-level-in-options
branch
from
98836d9
to
0e2a5b2
Compare
tiagogoncalves89
requested changes
Sep 16, 2021
test/logger.spec.ts
Outdated
| @@ -77,6 +77,23 @@ describe("simple-json-logger", () => { | |||
| // then | |||
| expect(instantiate).not.toThrow(); | |||
| }); | |||
|
|
|||
| it("Should set level when provied in options", () => { | |||
There was a problem hiding this comment.
I think it would be good if you test the another 2 test cases:
- When receive the log level from process.env;
- When set the default log level when don't have any other.
mikejavier
force-pushed
the
log-level-in-options
branch
from
0e2a5b2
to
6980f98
Compare
tiagogoncalves89
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.