Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Cython really necessary as a runtime dependency? #19

Closed
monosans opened this issue Apr 1, 2024 · 3 comments
Closed

Is Cython really necessary as a runtime dependency? #19

monosans opened this issue Apr 1, 2024 · 3 comments

Comments

@monosans
Copy link

monosans commented Apr 1, 2024

No description provided.

@Vizonex
Copy link
Owner

Vizonex commented Apr 1, 2024 via email

@monosans
Copy link
Author

monosans commented Apr 3, 2024

Yes, it is required at build time. But I am 99% sure it is not required at runtime.

lschoe added a commit that referenced this issue May 14, 2024
For the current version, the Winloop wheel on PyPI only needs 4 files to run: __init__py, _noop.py, _version.py, and loop.*.pyd. End users need not be bothered with cython.
@lschoe
Copy link
Collaborator

lschoe commented May 14, 2024

As fas as I can tell, cython is indeed not needed for the end users (who download the library as a wheel from PyPI).
So, I've removed the line install_requires=["cython"] from setup.py, see 7c1555f.

Anyone who wants to run python setup.py build_ext --inplace must have cython installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants