Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_dealloc. Use uv_pipe to avoid bad fds. #27

Merged
merged 1 commit into from
May 27, 2024

Conversation

lschoe
Copy link
Collaborator

@lschoe lschoe commented May 26, 2024

With uv_socketpair we get bad file descriptors and test_dealloc (and other tests) fail.

With uv_socketpair we get bad file descriptors and test_dealloc (and other tests) fail.
@lschoe
Copy link
Collaborator Author

lschoe commented May 26, 2024

Hi @Vizonex, can you check this PR?

Looks like using uv_pipe instead of uv_socketpair makes the bad fds disappear. In any case, test_dealloc passes this way, and also the bad fds are gone for test_context and test_signals (but these latter tests still have other issues).

Also, uv_pipe looks like a reasonable alternative for AF_UNIX sockets on Windows.

@Vizonex Vizonex merged commit 806ca50 into main May 27, 2024
@Vizonex
Copy link
Owner

Vizonex commented May 27, 2024

I'll let this one through let me make sure my version is up to date with this one by testing this on my computer

@Vizonex
Copy link
Owner

Vizonex commented May 27, 2024

Feel free to let me know when I can release 0.1.4

@lschoe
Copy link
Collaborator Author

lschoe commented May 28, 2024

Sure @Vizonex you can release 0.1.4 now. More updates will follow, but it's good to have this version tested already.
Make sure to include the Python 3.8 version and compile everything with cython==0.29.37 for best results.

@lschoe
Copy link
Collaborator Author

lschoe commented May 30, 2024

Managed to fix the publish workflow by adding the use of submodules, v0.1.4 is now on PyPI.

@Vizonex
Copy link
Owner

Vizonex commented Jun 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants