Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/Yarn and node 8 #114

Merged
merged 4 commits into from
Dec 6, 2017
Merged

Chore/Yarn and node 8 #114

merged 4 commits into from
Dec 6, 2017

Conversation

tsubik
Copy link
Contributor

@tsubik tsubik commented Dec 6, 2017

Overview

Introduces node 8 LTS version and yarn for deterministic dependency resolution.

Checklist

  • PR has a name that won't get you publicly shamed for vagueness
  • PR has a description that explains it
  • PR includes information for people to test it [e.g.: run npm install]
  • PR is not 2k commits long... please. 🙏 (lock files lol)

@tsubik tsubik requested a review from simaob December 6, 2017 12:39
@tsubik
Copy link
Contributor Author

tsubik commented Dec 6, 2017

One more commit I have to make to get rid of some warnings.

@tsubik
Copy link
Contributor Author

tsubik commented Dec 6, 2017

I had prop-types as the unmeet dependency so I've added it to package.json and followed upgrade path to import PropTypes from own library to get rid of most of the deprecation messages, the rest probably comes from third-party libs.

Copy link
Contributor

@simaob simaob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@simaob simaob merged commit 0c7f96e into master Dec 6, 2017
@simaob simaob deleted the chore/yarn-node-8 branch December 6, 2017 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants