Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/stay-updated-link #138

Merged
merged 2 commits into from
May 30, 2018
Merged

fix/stay-updated-link #138

merged 2 commits into from
May 30, 2018

Conversation

pjosh
Copy link

@pjosh pjosh commented May 30, 2018

@pjosh pjosh requested a review from edbrett May 30, 2018 10:05
edbrett
edbrett reviewed May 30, 2018
View reviewed changes
Copy link

@edbrett edbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still makes the page reload?

@pjosh
Copy link
Author

pjosh commented May 30, 2018

yeah of course, but in your current landing, not to the home page.
But, I know what you mean... It's better to change the behaviour and show the popup on click. I'm going to do that! thanks!

@pjosh
Copy link
Author

pjosh commented May 30, 2018

@edbrett done!

edbrett
edbrett approved these changes May 30, 2018
View reviewed changes
Copy link

@edbrett edbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hero we need 👏

@edbrett edbrett merged commit 4130e80 into develop May 30, 2018
@edbrett edbrett deleted the fix/stay-updated-link branch May 30, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbrett edbrett edbrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjosh @edbrett