Dropdown selector #117
Merged
Dropdown selector #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I'm on it. |
tsubik
suggested changes
Nov 18, 2019
|
I see that on your screenshots @aabdaab the dropdown has a good width. |
|
thanks for the review 🙏 i'm on it |
* Focus the input on opening the dropdown * On hitting escape, close dropdown * On click outside the search container, close dropdown * Fix dropdown width
|
Done:
|
rapzo
approved these changes
Nov 18, 2019
|
Added:
Before: After:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Dropdown Selector along with the fuzzy search functionality.
For fuzzy search fuse.js library is used. The dropdown component is custom.
On option selection, we are redirected to the sector/company's corresponding page.
Dropdown was added to three pages:
/tpi/sectors/- corresponds toAll sectionsoption/tpi/sectors/#{sector}- specific sector/tpi/companies/#{company}- specific company