Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ocd fixes #95

Merged
merged 6 commits into from
Nov 7, 2019
Merged

Feature/ocd fixes #95

merged 6 commits into from
Nov 7, 2019

Conversation

simaob
Copy link
Contributor

@simaob simaob commented Nov 6, 2019

In this PR:

  • sorts tags in forms (though for keywords it doesn't really seem to work with the case sensitivity, but I lost hope now);
  • sorts jurisdictions and geographies in forms;
  • includes instrument types in instruments form selection;
  • includes governance types in governances form selection;

I found out that formtastic hasn't been updated since 2017... and is a bit buggy and annoying.

@simaob simaob requested a review from tsubik November 6, 2019 21:49
@tsubik
Copy link
Contributor

tsubik commented Nov 6, 2019

Not good, I thought that last changes were this year, but I see no release in couple years. What can we do if we use active admin?

@simaob
Copy link
Contributor Author

simaob commented Nov 6, 2019

Damn, I pushed with broken specs apparently, sorry! Left the laptop in the office so can only fix tomorrow.

I was checking formtastic and they have commits early in the year, but no new releases. It kind of works, just needed to dig into the code to figure out some stuff. I should contribute some updates to the docs.

@tsubik
Copy link
Contributor

tsubik commented Nov 7, 2019

Right, that Tag select is broken. That must be select2 problem with some option.

Copy link
Contributor

@tsubik tsubik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 only that rubocop thing

I will try to fix that Tag Select in separate PR.

@tsubik
Copy link
Contributor

tsubik commented Nov 7, 2019

I see another problem with that tags component. Items are doubled when we select more than 1. I thought that worked fine.

@simaob
Copy link
Contributor Author

simaob commented Nov 7, 2019

What do you mean? doubled? I'll fix the rubocop complain and we can move on with this for now as you said.

@tsubik
Copy link
Contributor

tsubik commented Nov 7, 2019

image

Not sure what is causing this yet, but I'm going to fix that in separate PR.

@simaob
Copy link
Contributor Author

simaob commented Nov 7, 2019

I saw that, but when I clicked an existing one, it would deselect it. So I thought that it was fine...

I've fixed the rubocop issues and the deprecation warnings

@simaob simaob merged commit 38592ac into develop Nov 7, 2019
@simaob simaob deleted the feature/ocd-fixes branch November 7, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants