-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ocd fixes #95
Conversation
Not good, I thought that last changes were this year, but I see no release in couple years. What can we do if we use active admin? |
Damn, I pushed with broken specs apparently, sorry! Left the laptop in the office so can only fix tomorrow. I was checking formtastic and they have commits early in the year, but no new releases. It kind of works, just needed to dig into the code to figure out some stuff. I should contribute some updates to the docs. |
Right, that Tag select is broken. That must be select2 problem with some option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 only that rubocop thing
I will try to fix that Tag Select in separate PR.
I see another problem with that tags component. Items are doubled when we select more than 1. I thought that worked fine. |
What do you mean? doubled? I'll fix the rubocop complain and we can move on with this for now as you said. |
I saw that, but when I clicked an existing one, it would deselect it. So I thought that it was fine... I've fixed the rubocop issues and the deprecation warnings |
In this PR:
I found out that formtastic hasn't been updated since 2017... and is a bit buggy and annoying.