Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gmw multiple national dashboards #1003

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Conversation

mluena
Copy link
Collaborator

@mluena mluena commented Jan 8, 2024

Substitute this line for a meaningful title for your changes

Overview

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

Link to the related task manager tickets


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • Update CHANGELOG
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mangrove-atlas ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 3:18pm

@@ -170,7 +170,7 @@ const Legend = () => {

const title =
l.id === 'mangrove_national_dashboard_layer' && nationalDashboardLayerName
? `National Dashboard: ${nationalDashboardLayerName}`
? `National Dashboard`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need show info dialog or hide icon in case we cant show this detail

Copy link
Contributor

@anamontiaga anamontiaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i go to Australia, then i go to a place inside the country, i still have the layer in the legend but no details and no widget:

Screenshot 2024-01-09 at 19 59 25

@mluena mluena force-pushed the GMW-multiple-national-dashboards branch from 697b338 to a4413f0 Compare January 10, 2024 15:15
@mluena mluena merged commit e5fe87f into develop Jan 10, 2024
3 of 4 checks passed
@mluena mluena deleted the GMW-multiple-national-dashboards branch January 10, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants